Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: show ID when editing objects #6003

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Mar 4, 2024

Proposed change

Small thing I think we get with no real 'cost'. I actually thought of this the other day too when I was testing something out and wanted to know a tag's ID and realized its not that easy to look up.

E.g.
Screenshot 2024-03-04 at 2 08 50 PM
Screenshot 2024-03-04 at 2 21 13 PM

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner March 4, 2024 22:24
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Mar 4, 2024
@shamoon shamoon added this to the v2.6.0 milestone Mar 4, 2024
@shamoon shamoon enabled auto-merge (squash) March 4, 2024 23:15
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (6779042) to head (b768c08).

❗ Current head b768c08 differs from pull request most recent head 9772070. Consider uploading reports for the commit 9772070 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6003      +/-   ##
==========================================
- Coverage   97.03%   97.03%   -0.01%     
==========================================
  Files         414      413       -1     
  Lines       16552    16547       -5     
  Branches     1275     1247      -28     
==========================================
- Hits        16062    16057       -5     
  Misses        488      488              
  Partials        2        2              
Flag Coverage Δ
backend 95.82% <ø> (-0.01%) ⬇️
frontend 98.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon merged commit 00a8f0c into dev Mar 4, 2024
24 checks passed
@shamoon shamoon deleted the enhancement-show-id branch March 4, 2024 23:21
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants