Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: split user / group objects error #6302

Merged
merged 2 commits into from Apr 6, 2024
Merged

Fix: split user / group objects error #6302

merged 2 commits into from Apr 6, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 6, 2024

Proposed change

Closes #6296

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 6, 2024 13:55
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Apr 6, 2024
@shamoon shamoon changed the title Fix 6296 Fix: split user / group objects error Apr 6, 2024
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Apr 6, 2024
@shamoon shamoon enabled auto-merge (squash) April 6, 2024 13:55
@shamoon shamoon added this to the Next Release milestone Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (c4a9697) to head (fa45ed1).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6302   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         420      420           
  Lines       16917    16917           
  Branches     1286     1211   -75     
=======================================
  Hits        16431    16431           
  Misses        486      486           
Flag Coverage Δ
backend 95.94% <100.00%> (ø)
frontend 98.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon merged commit 957691c into dev Apr 6, 2024
31 checks passed
@shamoon shamoon deleted the fix-6296 branch April 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Status: Done
2 participants