Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: select dropdown background colors not visible in light mode #6323

Merged
merged 1 commit into from Apr 7, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 7, 2024

Proposed change

Fun with css inheritance

Screenshot 2024-04-07 at 11 36 56 AM Screenshot 2024-04-07 at 11 37 49 AM

Closes #6322

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 7, 2024 18:44
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Apr 7, 2024
@shamoon shamoon added this to the Next Release milestone Apr 7, 2024
@shamoon shamoon enabled auto-merge (squash) April 7, 2024 20:57
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (7afc91e) to head (03333e1).

❗ Current head 03333e1 differs from pull request most recent head e1f785a. Consider uploading reports for the commit e1f785a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6323      +/-   ##
==========================================
- Coverage   98.56%   97.12%   -1.44%     
==========================================
  Files         234      420     +186     
  Lines        7655    16918    +9263     
  Branches     1287     1257      -30     
==========================================
+ Hits         7545    16432    +8887     
- Misses        108      484     +376     
  Partials        2        2              
Flag Coverage Δ
backend 95.94% <ø> (?)
frontend 98.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon merged commit 0b34e70 into dev Apr 7, 2024
26 checks passed
@shamoon shamoon deleted the fix/dropdown-bg-colors branch April 7, 2024 21:03
DlieBG pushed a commit to DlieBG/paperless-ngx that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Not marking selection in Drop-Down-List
2 participants