Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: improve layout, button labels for custom fields dropdown #6362

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 10, 2024

Proposed change

Revamped:

Screenshot 2024-05-01 at 9 58 05 PM

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 10, 2024 16:12
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (40db106) to head (c1c3ba4).

❗ Current head c1c3ba4 differs from pull request most recent head 0c47f66. Consider uploading reports for the commit 0c47f66 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6362      +/-   ##
==========================================
+ Coverage   97.06%   97.12%   +0.06%     
==========================================
  Files         420      420              
  Lines       16893    16922      +29     
  Branches     1289     1256      -33     
==========================================
+ Hits        16397    16436      +39     
+ Misses        494      484      -10     
  Partials        2        2              
Flag Coverage Δ
backend 95.94% <ø> (+0.12%) ⬆️
frontend 98.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon added this to the Next Release milestone Apr 10, 2024
@shamoon shamoon enabled auto-merge (squash) April 10, 2024 19:14
@shamoon shamoon modified the milestones: Next Bugfix Release, Next Feature Release Apr 14, 2024
@shamoon shamoon force-pushed the cf-dropdown-usability-improvements branch from c1c3ba4 to 0c47f66 Compare April 19, 2024 06:50
@shamoon shamoon merged commit 78f3384 into dev Apr 19, 2024
25 checks passed
@shamoon shamoon deleted the cf-dropdown-usability-improvements branch April 19, 2024 06:57
danielrheinbay pushed a commit to danielrheinbay/paperless-ngx that referenced this pull request May 5, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants