Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: refactor monetary field #6370

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 10, 2024

Proposed change

I guess Im a sucker for obsessive stuff so I spent some time reworking this, I think the most important issue was the keyboard weirdness, which this should improve. Probably the single biggest thing is changing the track parameter to make angular change detection work better on these. See video which is 100% keyboard interaction except where obvious.

monetaryrefactor.mov

Related to #6357

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 10, 2024 23:12
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels Apr 10, 2024
@shamoon shamoon added this to the Next Release milestone Apr 10, 2024
@github-actions github-actions bot added the enhancement New feature label Apr 10, 2024
@shamoon shamoon enabled auto-merge (squash) April 10, 2024 23:13
@shamoon shamoon modified the milestones: Next Bugfix Release, Next Feature Release Apr 14, 2024
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly deferring to you one this

@shamoon shamoon force-pushed the feature-monetary-field-refactor branch from 7816b04 to 887c2f8 Compare April 19, 2024 08:01
@shamoon shamoon merged commit 95fd1ae into dev Apr 19, 2024
25 checks passed
@shamoon shamoon deleted the feature-monetary-field-refactor branch April 19, 2024 08:08
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants