-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: document history (audit log UI) #6388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6388 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 420 423 +3
Lines 16900 16964 +64
Branches 1290 1225 -65
=======================================
+ Hits 16402 16465 +63
- Misses 496 499 +3
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6fc5c70
to
0bbe8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two little things to keep the SQL minimal(ish)
Thanks stumpy, yea definitely want to do better looking out for those. Remind me, did you say there was a good tool to view the queries for a request? |
Not that I have found. I usually use the test, fail it delibratly so I can view stdout out, and use: from django.db import connection
from django.db import reset_queries
from pprint import pprint as print
reset_queries()
thing to look at
for x in connection.queries:
print(x) and kind of manually count the number and scope of queries. If you find something better, I'm all ears. Edit/Ps: I'm kind of looking through the views for more ones like this |
Awesome, yea that works. I just found https://github.com/jazzband/django-debug-toolbar but not trivial to install. Thanks for the snippet! |
9edc4f0
to
975429c
Compare
975429c
to
760c16b
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details. |
Proposed change
See screenshots, there are also some small improvements to the audit log.
Type of change
Checklist:
pre-commit
hooks, see documentation.