Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exclude admin perms from group permissions serializer #6608

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 7, 2024

Proposed change

Same as the fix we used for users

queryset=Permission.objects.exclude(content_type__app_label="admin"),

Closes #6607

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 7, 2024 13:44
@shamoon shamoon added this to the v2.8.2 milestone May 7, 2024
@shamoon shamoon enabled auto-merge (squash) May 7, 2024 13:44
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (fda4742) to head (9deb999).

❗ Current head 9deb999 differs from pull request most recent head c90bbf1. Consider uploading reports for the commit c90bbf1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6608   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         436      436           
  Lines       17933    17933           
  Branches     1514     1505    -9     
=======================================
  Hits        17429    17429           
- Misses        501      504    +3     
+ Partials        3        0    -3     
Flag Coverage Δ
backend 95.87% <ø> (ø)
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon merged commit 0d49314 into dev May 7, 2024
25 checks passed
@shamoon shamoon deleted the fix-6607 branch May 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Bug report or a Bug-fix small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Server Error 500 when granting History All
2 participants