Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dont use limit in subqueries in global search for mariadb compatibility #6611

Merged
merged 1 commit into from
May 7, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 7, 2024

Proposed change

Seems incredibly silly, but what do I know Django.

Closes #6605

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 7, 2024 14:32
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels May 7, 2024
@shamoon shamoon enabled auto-merge (squash) May 7, 2024 14:32
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 7, 2024
@shamoon shamoon added this to the v2.8.2 milestone May 7, 2024
@shamoon shamoon merged commit fae2399 into dev May 7, 2024
25 checks passed
@shamoon shamoon deleted the fix-6605 branch May 7, 2024 15:14
@shamoon shamoon changed the title Fix: dont use limit in subqueries for mariadb compatibility Fix: dont use limit in subqueries in global search for mariadb compatibility May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] [ERROR] [django.request] Internal Server Error: /api/search/
2 participants