Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(docs): Update the sample Compose file to latest database #6639

Merged
merged 1 commit into from May 8, 2024

Conversation

stumpylog
Copy link
Member

Proposed change

Both releases have been out for some time now and I didn't encounter any issues with either in testing.

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner May 8, 2024 15:48
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Databases make me nervous ha but agree seems like good housekeeping, thanks

@stumpylog
Copy link
Member Author

They should be well tested and any bugs with the major versions fixed by this point. That's why I waited a bit :)

@stumpylog stumpylog added the documentation Improvements or additions to documentation label May 8, 2024
@stumpylog stumpylog force-pushed the docs/update-compose-versions branch from 3fd6975 to fa4e73f Compare May 8, 2024 20:26
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (d4d0604) to head (3fd6975).

❗ Current head 3fd6975 differs from pull request most recent head fa4e73f. Consider uploading reports for the commit fa4e73f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6639      +/-   ##
==========================================
- Coverage   98.63%   97.19%   -1.44%     
==========================================
  Files         248      436     +188     
  Lines        8559    17957    +9398     
  Branches     1481     1480       -1     
==========================================
+ Hits         8442    17453    +9011     
- Misses        114      501     +387     
  Partials        3        3              
Flag Coverage Δ
backend 95.88% <ø> (?)
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog stumpylog enabled auto-merge (squash) May 8, 2024 20:26
@stumpylog stumpylog merged commit 48092d4 into dev May 8, 2024
27 checks passed
@stumpylog stumpylog deleted the docs/update-compose-versions branch May 8, 2024 20:32
@WebDucer
Copy link

How about the "migration" docs? As I know, switching Postgres versions is normally not enough (so it is not a "patch"), there is more work needed.

@stumpylog
Copy link
Member Author

Documentation already exists and is linked to from our documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants