Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only count inbox documents from inbox tags with permissions #6670

Merged
merged 1 commit into from
May 10, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 10, 2024

Proposed change

Slightly specific set of circumstances but surprised this hasn't come up already. The test here fails without the change.

Closes #6654

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 10, 2024 14:03
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels May 10, 2024
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 10, 2024
@shamoon shamoon enabled auto-merge (squash) May 10, 2024 14:03
@shamoon shamoon added this to the Next Release milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (74b8504) to head (2167fbd).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6670   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17968    17968           
  Branches     1523     1431   -92     
=======================================
  Hits        17464    17464           
- Misses        501      504    +3     
+ Partials        3        0    -3     
Flag Coverage Δ
backend 95.88% <ø> (ø)
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the diligence in tracking it down

@shamoon shamoon merged commit 6fa3522 into dev May 10, 2024
31 checks passed
@shamoon shamoon deleted the fix-6654 branch May 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Dashboard counts documents from inbox tags, user are unable to access.
2 participants