Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restore search highlighting on large cards results #6728

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 15, 2024

Proposed change

Closes #6717

Screenshot 2024-05-14 at 7 09 23 PM

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added this to the v2.8.5 milestone May 15, 2024
@shamoon shamoon requested a review from a team as a code owner May 15, 2024 02:11
@github-actions github-actions bot added the bug Bug report or a Bug-fix label May 15, 2024
@shamoon shamoon enabled auto-merge (squash) May 15, 2024 02:17
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (f45daa9) to head (c13afe2).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6728   +/-   ##
=======================================
  Coverage   97.19%   97.20%           
=======================================
  Files         436      436           
  Lines       17975    17975           
  Branches     1430     1430           
=======================================
+ Hits        17471    17472    +1     
+ Misses        504      503    -1     
Flag Coverage Δ
backend 95.89% <ø> (+0.01%) ⬆️
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon disabled auto-merge May 15, 2024 04:38
@shamoon shamoon merged commit 6546858 into dev May 15, 2024
31 checks passed
@shamoon shamoon deleted the fix-6717 branch May 15, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant