Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Title is changed after switching doc quickly #979

Merged
merged 2 commits into from May 18, 2022
Merged

Fix: Title is changed after switching doc quickly #979

merged 2 commits into from May 18, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 17, 2022

Proposed change

This PR fixes an issue where a document title would change after quickly switching between docs. The bug happens because of the debounce on the title field which incorrectly fired and changed the title even after switching to a new doc. Before and after video below. This is actually a tricky issue because if theres anything almost as confusing as timezones, its rxjs! But I think this should do it.

After:

after.mov

Before:

before.mov

Fixes #978

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 17, 2022 17:42
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 17, 2022
@shamoon shamoon self-assigned this May 17, 2022
@shamoon shamoon added this to the Next Release milestone May 17, 2022
Copy link
Member

@qcasey qcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that did the trick.

@shamoon shamoon merged commit f1e99de into dev May 18, 2022
@shamoon shamoon deleted the fix-978 branch May 18, 2022 09:55
@qcasey qcasey added the bug Bug report or a Bug-fix label May 18, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] When editing multiple files, a pending title change overwrites the title on unrelated open document
2 participants