Multi-line logs - stacktraces and others #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eive them as one line with correct source and application, and the following lines without correct hostname. This results in output looking like this: Jan 23 16:04:56 193.213.209.1 advisoradmin-server: INFO o.h.jpa.internal.util.LogHelper: HHH000204: Processing PersistenceUnitInfo [ Jan 23 16:04:56 193.213.209.1 logger: name: default Jan 23 16:04:56 193.213.209.1 logger: ...] This occurs due to papertrails not handling the newlines as part of the same message. In practice this means that filtering on hostname filters out the corresponding lines from the log(!) If, instead, we send the lines separately when logging on different lines, the lines will all contain the hostname. With this patch, the resulting output looks like this: Jan 23 16:17:01 193.213.209.1 advisoradmin-server: INFO o.h.jpa.internal.util.LogHelper: HHH000204: Processing PersistenceUnitInfo [ Jan 23 16:17:01 193.213.209.1 advisoradmin-server: name: default Jan 23 16:17:01 193.213.209.1 advisoradmin-server: ...] The downside, obviously, is more traffic when logging multi-line log lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a log event results in a multi-line output, papertrails will receive them as one line with correct source and application, and the following lines without correct hostname.
This results in output looking like this:
This occurs due to papertrails not handling the newlines as part of the same message. In practice this means that filtering on hostname filters out the corresponding lines from the log(!)
If, instead, we send the lines separately when logging on different lines, the lines will all contain the hostname.
With this patch, the resulting output looks like this:
The downside, obviously, is more traffic when logging multi-line log lines.