Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Implementing Export Function in ENEX format #41

Merged
merged 1 commit into from
Jan 7, 2015
Merged

Implementing Export Function in ENEX format #41

merged 1 commit into from
Jan 7, 2015

Conversation

Liongold
Copy link
Contributor

@Liongold Liongold commented Jan 2, 2015

Please do not merge this for now.

This is the first version of the export function. It exports all notes in an ENEX file. Could you please check it out?

I've added some strings in the en language. However, they are not added in de.

@Liongold Liongold mentioned this pull request Jan 2, 2015
@mrusme
Copy link
Member

mrusme commented Jan 3, 2015

It looks good from what I see within the diffs. The next step would be to check, if there was a way to use the internal Blade-Templating-Engine to generate the output file, so that you don't need to mix the "view" (XML structure of the export file) with the controller code. But that's only some cleaning that could be done at a some point in the future.

However, just tell me whether you're done with this and you want me to merge it, or if you'd still like to implement something.

Thanks again for your work! 👍

@Liongold
Copy link
Contributor Author

Liongold commented Jan 6, 2015

I'm trying to do the separation, as you've commented. It isn't ready for now yet. My pull request also includes a couple of strings. Will those be translated before merging or can be done after?

@mrusme
Copy link
Member

mrusme commented Jan 6, 2015

@Liongold the translation can be done later, since you probably don't know german or french, right? :-) Don't worry about that.

@Liongold
Copy link
Contributor Author

Liongold commented Jan 7, 2015

I've updated the request while adding the remaining strings. Please check it and if it's good, you can merge it ;)

@mrusme
Copy link
Member

mrusme commented Jan 7, 2015

Looks good! Great work, thank you!

mrusme added a commit that referenced this pull request Jan 7, 2015
Implementing Export Function in ENEX format
@mrusme mrusme merged commit 4990839 into paperwork:master Jan 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants