Allow restriction of tournaments on results screens #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is now implemented as I intended and is documented. This use case is probably rare, but at least there's an example of how to do something like this in the future. |
Amaras
commented
Jun 5, 2024
Comment on lines
+225
to
+238
| query_parts: list[str] = [] | ||
| params: tuple = () | ||
| for tournament in tournaments: | ||
| query_part: str = ('SELECT `tournament_id`, `round`, `board_id`, `white_player`, `black_player`, `date`, `value` ' | ||
| 'FROM `result` WHERE `tournament_id` = ? ORDER BY `date` DESC') | ||
| params += (tournament, ) | ||
| if limit: | ||
| query_part += ' LIMIT ?' | ||
| params += (limit, ) | ||
| query_parts.append('\n'.join(('SELECT * FROM (', query_part, ')'))) | ||
| query: str = '\nUNION\n'.join(query_parts) + ' ORDER BY `date` DESC' | ||
| if limit: | ||
| query += ' LIMIT ?' | ||
| params += (limit, ) |
There was a problem hiding this comment.
Check if IN (?, ?, ...) pattern is possible in SQLITE prepared statements
…-web-org/papi-web into results_screen_multiple_tournaments
pascalaubry
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of results screens mentioned in #27: only include specified tournaments in a screen of type
results.This is untested for now (coded on Linux), as the query can be quite problematic.
Documentation was not modified to reflect the change yet.