Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papis doctor: various quirks #849

Closed
jghauser opened this issue May 13, 2024 · 2 comments · Fixed by #854
Closed

papis doctor: various quirks #849

jghauser opened this issue May 13, 2024 · 2 comments · Fixed by #854

Comments

@jghauser
Copy link
Member

I just started using papis doctor and noticed I got a lot of keys-exist messages. When I checked, it was because certain keys were missing. Maybe we might want to rename that to key-missing or something of that sort?

@jghauser
Copy link
Member Author

Also, should there really be a keys-exist error for author and author_list if the entry has editor (or editor_list I suppose)? I have a couple of documents that are just collections of articles and don't have an author as such.

@jghauser jghauser changed the title Papis doctor: keys-exist papis doctor: various quirks May 13, 2024
@alexfikl
Copy link
Collaborator

Agreed that the rename would be nice!

Also, should there really be a keys-exist error for author and author_list if the entry has editor (or editor_list I suppose)? I have a couple of documents that are just collections of articles and don't have an author as such.

The keys-exist check is intentionally pretty dumb because it's a very general "tell me if these documents have this key" thing. I would argue that at least for now, it's good to warn about author and author_list because the rest of the code doesn't really know how to handle things like editor (which are effectively aliases for author in many situations).

There's also a biblatex-required-keys check that's a bit smarter about what keys are required for what type of document. Maybe we can make that the default instead of keys-exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants