Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedup redundant type/kind info by simplifying full signature generation #179

Merged
merged 2 commits into from Nov 19, 2021
Merged

Dedup redundant type/kind info by simplifying full signature generation #179

merged 2 commits into from Nov 19, 2021

Commits on Nov 19, 2021

  1. Dedup redundant type/kind info by simplifying full signature generation 

    For completions that don't have a signature, `BaseName.description`
provides type, name, and typing information if it was explicitly
written.  For completions that provide signatures, `.to_string` provides
the parameters and typing information that needs to be appended to the
type.

`get_type_hints()` is an expensive call that calls into `jedi.infer()`,
even for completions that have explicit typing information.
    @ericvw
    ericvw committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    6914277 View commit details
    Browse the repository at this point in the history

  2. Partially revert "Update tests to reflect new hover docs" 

    This partially reverts commit 8ee2138
by restoring the former expected behavior for how the header is rendered
when hovering over a module due to the simplified approach for obtaining
the full signatures.
    @ericvw
    ericvw committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    e782ece View commit details
    Browse the repository at this point in the history