Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: DCLP and principal edition #290

Open
samosafuz opened this issue Jun 29, 2021 · 0 comments
Open

Bug: DCLP and principal edition #290

samosafuz opened this issue Jun 29, 2021 · 0 comments

Comments

@samosafuz
Copy link
Member

I finalized TM 64677 this morning, and when I reviewed the file I noticed that the principal edition is absent from the displayed DCLP meta.

Screen Shot 2021-06-29 at 9 32 46 AM

I seem to recall seeing this on another occasion, and I've now diagnosed the issue. In the XML, one finds the principal edition encoded as <bibl n="1" type="edition" subtype="principal">, whereas in other files (where the principal edition does display correctly) one finds <bibl n="1" type="publication" subtype="principal">.

The following 39 files all include the faulty code:

60614.xml
60539.xml
60698.xml
60296.xml
60668.xml
65146.xml
65385.xml
65056.xml
65367.xml
65612.xml
66070.xml
59496.xml
59447.xml
59556.xml
59953.xml
59847.xml
64846.xml
64173.xml
64612.xml
64391.xml
64037.xml
64327.xml
64281.xml
61246.xml
61800.xml
61608.xml
61311.xml
62505.xml
62680.xml
62724.xml
62492.xml
62151.xml
129740.xml
63194.xml
63786.xml
63602.xml
69036.xml
121928.xml
121929.xml

I tested a random sample of these files and, indeed, none of them currently display the principal edition in PN.

It's easy enough to correct the XML, but I'm flagging this issue because something has gone wrong in the DCLP metadata mask: faulty XML is being produced when @principal is selected from the biblio dropdown menu. I'm not sure how this came about.

In the case of TM 64677 (FWIW), the default edition type was @reference (i.e., <bibl type="reference" subtype="principal">) and I updated it to @principal in the course of finalizing the file. It is perhaps the case that changing from one edition type to @principal in the dropdown menu is the problem. But it may also be systemic.

samosafuz added a commit to samosafuz/idp.data that referenced this issue Jul 8, 2021
One last change for #[290](papyri/sosol#290).
samosafuz added a commit to samosafuz/idp.data that referenced this issue Jul 9, 2021
I finalized this file today, and noticed afterward that it was affected by issue #[290](papyri/sosol#290), which this update resolves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant