Fixes #45 #46
Merged
Fixes #45 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stu Goodman <stuart177@gmail.com>
|
Looks great. I'll check it out when I'm back home and merge it |
|
I think the error comes from line 124 in the test. |
|
Fixed your test and added to additional ones specific to setUpParams. merged! 👍 |
|
Ah doh. Good spot. Edit: Also something I noticed, is it worth having a .gitignore for things like the vendor folder and OS files etc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the $data parameter on setUpParams() to accept Arrays if an Array is passed to it, allowing multiple additional fields to be declared when making a request.
I've created a test which I think so be right however I can't get it to run locally, getting an NoMatchingExpectationException error from Mockery.