Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Add LayoutBuilder to Widgets to utilize constraints. #99

Closed
SuperGNUS opened this issue Oct 5, 2020 · 2 comments · Fixed by #129
Closed

Add LayoutBuilder to Widgets to utilize constraints. #99

SuperGNUS opened this issue Oct 5, 2020 · 2 comments · Fixed by #129
Labels
enhancement New feature or request refactor

Comments

@SuperGNUS
Copy link
Contributor

Change Proposal

Right now the code uses MediaQuery.Of(context) to set positions, padding, etc. This should really be using constraints passed in that are the parent container, which is not necessarily the full screen or even the SafeArea()

Module and Current Solution

Alignment Service will be effected, and we will need to pass constraints parameters to all child widgets (which is good for using symbols).

Benefits of the Change

What improvements occur because of this change? (Readability, Performance, Scalability, etc...)
Scalability is improved.

@SuperGNUS SuperGNUS added enhancement New feature or request refactor labels Oct 5, 2020
@SuperGNUS
Copy link
Contributor Author

This can be closed with pull request #129

@siliconivan siliconivan linked a pull request Oct 21, 2020 that will close this issue
@siliconivan
Copy link
Member

Thanks for the PR link comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants