Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node dev piping broken #72

Closed
jordanh opened this issue Jun 23, 2016 · 3 comments
Closed

node dev piping broken #72

jordanh opened this issue Jun 23, 2016 · 3 comments

Comments

@jordanh
Copy link
Contributor

jordanh commented Jun 23, 2016

Issue - Bug

@mattkrick:

piping is broken & i'm not sure why. When it auto-restarts, i get EADDRESSINUSE almost always. Also, it only worked in development, and we should be debugging server code in production.

@jordanh:

This has been driving me nuts. Let's create an issue. I suspect it's because the SC worker process isn't exiting.

I want to track this down either via a git bisect and a test script or adding a hook on exit that looks at node's run queue.

@jordanh
Copy link
Contributor Author

jordanh commented Jun 26, 2016

So this is goofy. I tried to reproduce this on the airplane over to Germany and now I couldn't get it to break. Before I began I toasted an reinstalled node_modules. Is this still failing reliably for you @mattkrick?

@jordanh
Copy link
Contributor Author

jordanh commented Jul 7, 2016

@mattkrick you pulled piping out of the codebase right? I bet it was related to why npm run build:server was failing. I wonder if it would work again if you re-added it?

@mattkrick
Copy link
Member

Yup. TBH I don't miss it, but we can add in back in. If we do, we should turn it on only if a DEPLOY environment variable is false since it's only really useful when we're in __PRODUCTION__ (if we're in dev mode that means waiting 15+ seconds for the server to restart & recompile the entire client webpack in memory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants