-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create cargo-paradedb for easy dev script execution #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5979d25
to
07f82b3
Compare
9b8671c
to
9b1711c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add the results to pg_search/benchmarks/README.md and to pg_analytics/benchmarks/README.md and it'll be good to go for me. Thank you for doing this!
proper install add url install docs Add corpus function Add generate corpus function Fix workspace formatting Remove testcontainers Prettier Remove tryfrom Readme wording Readme wording Readme heading Parametrize events add repeat arg add seed arg add insert command setup tracing add postgres insert methods fix types finish bench generate fix comment update index debug update index debug update index debug again remove logging namespace corpus build index + print
6039798
to
ce9501b
Compare
9749f90
to
ce9501b
Compare
philippemnoel
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
pg_search
andpg_analytics
#1018What
To facilitate tasks like setting up benchmarks in CI/EC2 instances, I've made a Rust CLI that can optionally be installed globally.
Why
As we start to require more sophisticated testing and benchmark environments, we'll want reproducible scripts that can generate/process data and run tasks.
We can use Cargo's wonderful
install
feature to install all our tools and dependencies at once in any environment. For many tasks in containers/instances, this will be the only setup command we'll need:How
By the magic of
clap
, Rust's de-facto CLI builder, andcmd_lib
, which has a brilliant syntax for running subprocesses.Tests
Ideally, we'd have a suite that tests all this scripts, probably in isolated docker environments with
testcontainers
. But we can save that for when our tasks become more complex and more frequently run.