Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing lint workflows that are only caught in pre-commit #473

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

philippemnoel
Copy link
Collaborator

@philippemnoel philippemnoel commented Nov 1, 2023

Ticket(s) Closed

  • Closes #

What

This PR adds missing linting workflows to our repo. We were not linting for trailing whitespaces and for TypeScript/JSON/etc. files, which led to all CI passing while pre-commit hooks not passing. This should not standardize everything!

Why

How

Tests

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
paradedb ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 8:14pm

@philippemnoel philippemnoel merged commit 121a589 into dev Nov 1, 2023
8 checks passed
@philippemnoel philippemnoel deleted the phil/preco-missing branch November 1, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant