-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Lindera tokenizer #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #567 +/- ##
==========================================
+ Coverage 60.14% 68.31% +8.17%
==========================================
Files 42 28 -14
Lines 3475 2888 -587
==========================================
- Hits 2090 1973 -117
+ Misses 1385 915 -470
|
neilyio
reviewed
Nov 25, 2023
rebasedming
force-pushed
the
rebasedming/tokenizers
branch
from
November 26, 2023 00:07
4958261
to
50df303
Compare
neilyio
approved these changes
Nov 27, 2023
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Introduces the Lindera tokenizer, which adds advanced tokenization support for Korean, Japanese, and Chinese.
Usage:
Why
Our CJK tokenizer is a bit simplistic, splitting words by spaces. In languages like Japanese, word boundaries are not always defined by spaces. The Lindera tokenizer splits words into tokens using a language-specific dictionary.
How
Uses the
lindera
Rust crates.Tests