feat: Enable benchmark-paradedb.sh to benchmark any tag, including build from source
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
philippemnoel
force-pushed
the
phil/fix-bench
branch
from
19c3dec
to
de0cf9b
Compare
philippemnoel
force-pushed
the
phil/fix-bench
branch
from
9e5cecc
to
7541815
Compare
|
This can now be run locally, so we can use it to fix the syntax in the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
@neilyio helped me realize that our benchmarking script was testing
mainnightly, instead ofdevlike I had assumed. I guess we made it quickly to be able to benchmark against other systems, but now need to start benchmarking across versions of ParadeDB. To do this, benchmarkingdevnightly is better. We also need to be able to benchmark locally easily, for local development.This PR does this by replacing the hard-coded version
latestfor ParadeDB by an arbitrary version. We can now also provide-t localto build the Dockerfile locally, on the current commit. I updated the CI to do local build, to test currentdevat each run.Why
^
How
^
Tests
https://github.com/paradedb/paradedb/actions/runs/7039250468