fix: build edge-cases with pgrx =0.11.1 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
requested review from
rebasedming,
sardination,
neilyio and
philippemnoel
as code owners
|
@workingjubilee is attempting to deploy a commit to the ParadeDB Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #578 +/- ##
==========================================
- Coverage 61.52% 61.07% -0.46%
==========================================
Files 43 43
Lines 3680 3717 +37
==========================================
+ Hits 2264 2270 +6
- Misses 1416 1447 +31
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@GPF199541 This should be an appropriate patch to make the source build work on your machine without needing to set any env vars or anything. Probably. |
|
Thank you @workingjubilee! |
workingjubilee
deleted the
fix-builds-for-fucked-up-centos-envs-maybe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Fixes several weird build edge-cases.
Why
These edge-cases prevent local builds from resolving correctly. These seem to disproportionately afflict CentOS 7, but they can arise in other build environments such as Debian, unless you carefully manage the build environment with e.g. Docker.
How
Upgrade pgrx to
=0.11.1.Tests
It does update all the workflows, of course, though I do not believe you wish to run a CentOS 7 test server at this time to test the exact edge-case in question.