Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CI #579

Merged
merged 9 commits into from
Nov 29, 2023
Merged

fix: Fix CI #579

merged 9 commits into from
Nov 29, 2023

Conversation

philippemnoel
Copy link
Collaborator

@philippemnoel philippemnoel commented Nov 29, 2023

Ticket(s) Closed

  • Closes #N/A

What

The tests were starting to fail on Postgres 15. After much trial and error I realized the issue is probably we didn't set the permissions to access the PGDATA folder, which for some reason only showed up on 15. This fixes it.

Why

How

Tests

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
paradedb ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 8:12pm

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #579 (3ac173f) into dev (ed8fd71) will decrease coverage by 0.46%.
Report is 3 commits behind head on dev.
The diff coverage is 42.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #579      +/-   ##
==========================================
- Coverage   61.52%   61.07%   -0.46%     
==========================================
  Files          43       43              
  Lines        3680     3717      +37     
==========================================
+ Hits         2264     2270       +6     
- Misses       1416     1447      +31     
Files Coverage Δ
pg_bm25/src/parade_index/index.rs 71.61% <80.00%> (+0.03%) ⬆️
pg_bm25/src/json/builder.rs 24.03% <0.00%> (-2.28%) ⬇️
pg_bm25/src/index_access/utils.rs 61.82% <47.50%> (-5.46%) ⬇️

@philippemnoel philippemnoel changed the title fix: Try to fix CI fix: Fix CI Nov 29, 2023
@philippemnoel philippemnoel marked this pull request as ready for review November 29, 2023 20:16
@philippemnoel philippemnoel merged commit 5991bec into dev Nov 29, 2023
25 of 26 checks passed
@philippemnoel philippemnoel deleted the phil/fix-ci branch November 29, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant