Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean previous build artifacts to avoid conflicts #597

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

philippemnoel
Copy link
Collaborator

@philippemnoel philippemnoel commented Nov 30, 2023

Ticket(s) Closed

  • Closes #

What

The issue with the tests and the extension re-installing is due to the Rust cache caching previous extension versions. This should be the actual fix for it!

see here: https://doc.rust-lang.org/cargo/commands/cargo-clean.html

Why

How

Tests

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
paradedb ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 11:32pm

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #597 (83d7020) into dev (83fd8f1) will increase coverage by 0.15%.
Report is 2 commits behind head on dev.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #597      +/-   ##
==========================================
+ Coverage   81.44%   81.60%   +0.15%     
==========================================
  Files          30       30              
  Lines        3703     3707       +4     
==========================================
+ Hits         3016     3025       +9     
+ Misses        687      682       -5     

see 3 files with indirect coverage changes

@philippemnoel philippemnoel marked this pull request as ready for review December 1, 2023 00:45
@philippemnoel philippemnoel merged commit 8a085a3 into dev Dec 1, 2023
17 checks passed
@philippemnoel philippemnoel deleted the phil/fix-cache branch December 1, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant