Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Better error handling #783

Merged
merged 6 commits into from Jan 28, 2024
Merged

chore: Better error handling #783

merged 6 commits into from Jan 28, 2024

Conversation

rebasedming
Copy link
Collaborator

Ticket(s) Closed

  • Closes #

What

Better error handling

Why

How

A few changes:

  • Unwraps the error instead of expecting it in the pg_extern funcitons so the actual error messages get printed
  • Introduces ParadeError::NoneError that prints the type

Tests

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (98c7dff) 46.89% compared to head (522c236) 1.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #783       +/-   ##
==========================================
- Coverage   46.89%   1.25%   -45.64%     
==========================================
  Files          63      34       -29     
  Lines        7609    3353     -4256     
==========================================
- Hits         3568      42     -3526     
+ Misses       4041    3311      -730     
Files Coverage Δ
pg_analytics/src/hooks/handler.rs 0.00% <0.00%> (ø)
pg_analytics/src/datafusion/catalog.rs 0.00% <0.00%> (ø)
pg_analytics/src/datafusion/table.rs 0.00% <0.00%> (ø)
pg_analytics/src/api/init.rs 50.00% <0.00%> (-10.00%) ⬇️
pg_analytics/src/tableam/create.rs 0.00% <0.00%> (ø)
pg_analytics/src/hooks/mod.rs 0.00% <0.00%> (ø)
pg_analytics/src/errors.rs 0.00% <0.00%> (ø)
pg_analytics/src/hooks/executor.rs 0.00% <0.00%> (ø)
pg_analytics/src/tableam/insert.rs 0.00% <0.00%> (ø)
pg_analytics/src/datafusion/context.rs 0.00% <0.00%> (ø)
... and 2 more

... and 32 files with indirect coverage changes

@rebasedming rebasedming merged commit e6fad26 into dev Jan 28, 2024
14 checks passed
@rebasedming rebasedming deleted the chore/better-errors branch January 28, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant