Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only generate profraw in CI #810

Merged
merged 2 commits into from Feb 2, 2024
Merged

fix: Only generate profraw in CI #810

merged 2 commits into from Feb 2, 2024

Conversation

philippemnoel
Copy link
Collaborator

@philippemnoel philippemnoel commented Feb 2, 2024

Ticket(s) Closed

What

Only generate code coverage in CI, to avoid it clogging the local folders/builds

Why

^

How

Moved the Cinstrument-coverage to the CI, instead of the .cargo/config.toml file

Tests

Need to check that it still properly generates the code coverage

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@73beafa). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #810   +/-   ##
======================================
  Coverage       ?   32.45%           
======================================
  Files          ?       79           
  Lines          ?     7682           
  Branches       ?        0           
======================================
  Hits           ?     2493           
  Misses         ?     5189           
  Partials       ?        0           

@philippemnoel philippemnoel marked this pull request as ready for review February 2, 2024 20:36
@philippemnoel philippemnoel merged commit 79be49e into dev Feb 2, 2024
18 checks passed
@philippemnoel philippemnoel deleted the phil/profraw branch February 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pg_analytics generate default_xxx.profraw files in $CWD folder. how to disable it?
1 participant