New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pg_dump
support + schema evolution
#837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rebasedming
force-pushed
the
feat/scan
branch
2 times, most recently
from
February 12, 2024 18:54
6134917
to
b2cb1a1
Compare
rebasedming
changed the title
feat:
feat: Feb 13, 2024
pg_dump
supportpg_dump
support + schema evolution
rebasedming
force-pushed
the
feat/scan
branch
from
February 13, 2024 17:04
31c56a3
to
4227ecd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #837 +/- ##
==========================================
- Coverage 30.93% 0.00% -30.94%
==========================================
Files 84 45 -39
Lines 8060 4500 -3560
==========================================
- Hits 2493 0 -2493
+ Misses 5567 4500 -1067
|
neilyio
reviewed
Feb 13, 2024
neilyio
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Implements the tableAM scan methods, which are used by the
COPY to STDOUT
command (invoked by pg_dump). Also handlesADD/DROP/RENAME
column correctly.How to test:
cargo pgrx run
, create a deltalake table.pg_dump
Make sure the replace
username
with your username. This will create a dump of your database tosample_db_backup.sql
.Why
Enables users to back up deltalake tables with
pg_dump
.How
Two changes:
ALTER
statements on deltalake tables to allow more statements to pass through the Postgres. Also enabled users to runADD COLUMN
over deltalake tables.Tests
See new tests.