Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix parity with online docs #839

Merged
merged 2 commits into from Feb 13, 2024
Merged

docs: fix parity with online docs #839

merged 2 commits into from Feb 13, 2024

Conversation

CoderJoshDK
Copy link
Contributor

What

Primary motivation for this change, was /issues/836. As discussed there, there were broken links. In the process of fixing those links, parity between what the site looked like and the file structure of the source code was brought closer in line.

One thing to note, is paradedb/paradedb/commit/68ed49bc193926976b7f5afb1b0e6f0201dae41c This is where the deprecated docs were deleted. In that process, the link to it is no longer valid. Some liberties were needed to be made, to make the deprecated page still make sense

docs(prettier): update prettier ignore settings

New doc pages have new paths. Updates those paths in .prettierignore for the pre-commit stage

Ticket(s) Closed

Why

As discussed in #836 , there were broken links in the docs. Upon further investigation, the whole doc source was never cleaned up since the recent reworks. This PR aims to clean up and lower the discrepancies hosted docs and their source code.

How

Updates links and creates new directories.
.prettierignore was also updated.
Created directories:

  • docs/full-text/
  • docs/hybrid/
  • docs/similarity/

Tests

N/A

Primary motivation for this change, was /issues/836.
As discussed there, there were broken links. In the process of fixing
those links, parity between what the site looked like and the file
structure of the source code was brought closer in line.

One thing to note, is paradedb/paradedb/commit/68ed49bc193926976b7f5afb1b0e6f0201dae41c
This is where the deprecated docs were deleted. In that process, the
link to it is no longer valid. Some liberties were needed to be made, to
make the deprecated page still make sense

docs(prettier): update prettier ignore settings

New doc pages have new paths. Updates those paths in `.prettierignore`
for the pre-commit stage
@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024

CLA assistant check
All committers have signed the CLA.

To prevent /issues/836 (broken links) from happening in the future, a
CI step is recommended. This pre-commit *should* prevent it from causing
issues again.
@CoderJoshDK
Copy link
Contributor Author

As per ecb1fec, I added a CI step into the pre-commits. I hope it helps and you guys like it.

Copy link
Collaborator

@philippemnoel philippemnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for your contribution

@philippemnoel philippemnoel merged commit 87e7f25 into paradedb:dev Feb 13, 2024
5 checks passed
@CoderJoshDK CoderJoshDK deleted the doc-parity branch February 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Broken links
3 participants