Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dedup search, add schema to hybrid func, fix delete error #915

Merged
merged 7 commits into from Feb 27, 2024

Conversation

neilyio
Copy link
Contributor

@neilyio neilyio commented Feb 26, 2024

What

Fixing a few small issues with rank_hybrid, as well as handling a unusual deletion case we're seeing in CI.

  • rank_hybrid was not previously working with schemas not on the search_path.
  • rank_hybrid was returning stale rows when used outside of Postgres index scan, because we couldn't rely on Postgres filtering.
  • Deleting Tantivy files occasionally fails, because we try to delete a file that doesn't exist. We now just check for a NotFound error, and ignore it if we see it.

Tests

New test to confirm rank_hybrid results.

@neilyio neilyio merged commit fcc2627 into dev Feb 27, 2024
13 checks passed
@neilyio neilyio deleted the neil/dedup-search branch February 27, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants