feat: bls12-381 g1_add precompile #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
force-pushed
the
fgimenez/eip2537-precompiles
branch
2 times, most recently
from
f9369a8
to
34d1b60
Compare
Rjected
requested changes
Mar 19, 2024
cool thanks! ok, all the comments are addressed PTAL. wrt to the submodule doc, do you think we could include |
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
fgimenez
force-pushed
the
fgimenez/eip2537-precompiles
branch
from
ab53503
to
21e3d06
Compare
mattsse
requested changes
Mar 20, 2024
crates/node/src/evm.rs
Outdated
Comment on lines
47
to
55
| precompiles.inner.insert(BLS12_G1ADD.0, BLS12_G1ADD.1); | ||
| precompiles.inner.insert(BLS12_G1MUL.0, BLS12_G1MUL.1); | ||
| precompiles.inner.insert(BLS12_G1MULTIEXP.0, BLS12_G1MULTIEXP.1); | ||
| precompiles.inner.insert(BLS12_G2ADD.0, BLS12_G2ADD.1); | ||
| precompiles.inner.insert(BLS12_G2MUL.0, BLS12_G2MUL.1); | ||
| precompiles.inner.insert(BLS12_G2MULTIEXP.0, BLS12_G2MULTIEXP.1); | ||
| precompiles.inner.insert(BLS12_PAIRING.0, BLS12_PAIRING.1); | ||
| precompiles.inner.insert(BLS12_MAP_FP_TO_G1.0, BLS12_MAP_FP_TO_G1.1); | ||
| precompiles.inner.insert(BLS12_MAP_FP2_TO_G2.0, BLS12_MAP_FP2_TO_G2.1); |
There was a problem hiding this comment.
should we extract this to a helper function, so this setup can be reused?
There was a problem hiding this comment.
good point, done here e008ab3 PTAL
There was a problem hiding this comment.
I've taken a similar approach for instructions here https://github.com/paradigmxyz/alphanet/pull/17/files/e008ab32fe797b04cd4025307747840938fef295..0835e75b413d11182d6d5ab2cdc199af845d2164
Rjected
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11
Implements the
BLS12_G1ADDprecompile using thebls12_381crate. This crate has been selected overblstbecause it exposes a much more ergonomic interface to be used from Rust code.This implementation follows the spec at https://eips.ethereum.org/EIPS/eip-2537. Specifically, the logic takes into account the padding to specific lengths and the special encoding for the point of infinity as described here https://eips.ethereum.org/EIPS/eip-2537#point-of-infinity-encoding
It includes tests based on the test vectors defined for geth here https://github.com/ethereum/go-ethereum/blob/ab49f228ad6f37ba78be66b34aa5fee740245f57/core/vm/testdata/precompiles/blsG1Add.json for the happy path and here for the unhappy https://github.com/ethereum/go-ethereum/blob/ab49f228ad6f37ba78be66b34aa5fee740245f57/core/vm/testdata/precompiles/fail-blsG1Add.json (geth is one of the reference implementations cited in the spec https://eips.ethereum.org/EIPS/eip-2537#reference-implementation)
The PR also adds precompile functions for the rest of
BLS12-381precompiles still unimplemented, and includes all of them in the node.