Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement g2_add #32

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat: implement g2_add #32

merged 1 commit into from
Apr 4, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Apr 4, 2024

Towards #11

I needed to remove some of the entries in the test vector from https://github.com/ethereum/go-ethereum/blob/ab49f228ad6f37ba78be66b34aa5fee740245f57/core/vm/testdata/precompiles/blsG2Add.json because of oddLength errors, indeed some of the values where 511 hex chars instead of 512 or 1023 instead of 1024, these are the wrong inputs:

odd length in expected of matter_g2_add_5, 511
odd length in expected of matter_g2_add_7, 511
odd length in expected of matter_g2_add_21, 511
odd length in input of matter_g2_add_33, 1023
odd length in expected of matter_g2_add_37, 511
odd length in expected of matter_g2_add_68, 511
odd length in input of matter_g2_add_71, 1023
odd length in input of matter_g2_add_83, 1023
odd length in input of matter_g2_add_91, 1023

I'll report upstream.

@fgimenez fgimenez requested review from Rjected and mattsse April 4, 2024 10:34
@fgimenez fgimenez mentioned this pull request Apr 4, 2024
@fgimenez fgimenez changed the title feat: implemetn bls12 g2add feat: implemetn g2_add Apr 4, 2024
@fgimenez fgimenez changed the title feat: implemetn g2_add feat: implement g2_add Apr 4, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good to me!

@Rjected
Copy link
Member

Rjected commented Apr 4, 2024

I'll report upstream

Yeah, makes sense, definitely do that

@fgimenez fgimenez merged commit aa8da86 into main Apr 4, 2024
13 checks passed
@fgimenez fgimenez deleted the fgimenez/bls12-g2add branch April 6, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants