Decrease Docker image size, fixes #33 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Jul 25, 2023
Dockerfile
Outdated
Comment on lines
25
to
30
| ENV PATH="${PATH}:/home/${USERNAME}/.local/bin" | ||
| RUN adduser $USERNAME | ||
| USER $USERNAME | ||
|
|
||
| # install vegeta | ||
| RUN mkdir -p /home/$USERNAME/bin/vegeta_files | ||
| WORKDIR /home/$USERNAME/bin/vegeta_files | ||
| RUN wget https://github.com/tsenart/vegeta/releases/download/v12.8.4/vegeta_12.8.4_linux_amd64.tar.gz | ||
| RUN tar xzf vegeta_12.8.4_linux_amd64.tar.gz | ||
| RUN ln -s /home/$USERNAME/bin/vegeta_files/vegeta /home/$USERNAME/bin/vegeta | ||
| COPY --from=flood-builder /home/$USERNAME/.local /home/$USERNAME/.local | ||
| COPY --from=vegeta-builder /vegeta/vegeta /home/$USERNAME/bin/vegeta |
There was a problem hiding this comment.
Vegeta needs to either be moved to ~/.local/bin or you need to add ~/bin/ to the PATH
|
thanks for the PR @lgingerich. want to make the docker image as useful as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce the Docker size as referenced in Issue #33
Solution
PR Checklist
Metrics
There also seems to be a decrease in build time with this update although I didn't properly benchmark that.