Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExEx metrics panels #7572

Closed
Tracked by #7549
onbjerg opened this issue Apr 11, 2024 · 6 comments · Fixed by #7605
Closed
Tracked by #7549

ExEx metrics panels #7572

onbjerg opened this issue Apr 11, 2024 · 6 comments · Fixed by #7605
Assignees
Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 11, 2024

Describe the feature

We added metrics in #7340 and we should add panels for these

/// Metrics for an ExEx.
#[derive(Metrics)]
#[metrics(scope = "exex")]
struct ExExMetrics {
/// The total number of canonical state notifications sent to an ExEx.
notifications_sent_total: Counter,
/// The total number of events an ExEx has sent to the manager.
events_sent_total: Counter,
}

/// Metrics for the ExEx manager.
#[derive(Metrics)]
#[metrics(scope = "exex_manager")]
pub struct ExExManagerMetrics {
/// Max size of the internal state notifications buffer.
max_capacity: Gauge,
/// Current capacity of the internal state notifications buffer.
current_capacity: Gauge,
/// Current size of the internal state notifications buffer.
///
/// Note that this might be slightly bigger than the maximum capacity in some cases.
buffer_size: Gauge,
}

Additional context

No response

@onbjerg onbjerg added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-observability Related to tracing, metrics, logs and other observability tools A-exex Execution Extensions labels Apr 11, 2024
@mw2000
Copy link
Contributor

mw2000 commented Apr 12, 2024

Would love to take this on

@onbjerg
Copy link
Member Author

onbjerg commented Apr 12, 2024

Cool, thanks @mw2000! Let me know if you get stuck 😄 Do you have a rough timeline?

@mw2000
Copy link
Contributor

mw2000 commented Apr 12, 2024

Ideally this weekend! I'll take a first pass at it today in case I have more questions @onbjerg

@mw2000
Copy link
Contributor

mw2000 commented Apr 12, 2024

@onbjerg here's a first pass at it -> #7605

Pretty much used similar panels that we had for blockchain_tree_canonical_chain_height.

A bit green when it comes to grafana dashboards, but I was seeing the following on my end:

Screenshot 2024-04-12 at 11 27 04 AM

As opposed to what the blockchain_tree_canonical_chain_height panel looks like:
Screenshot 2024-04-12 at 11 27 53 AM

Is there a misconfig in the code for the exex panels somewhere? I'll also double check from my side in the meantime

@onbjerg
Copy link
Member Author

onbjerg commented Apr 14, 2024

No, the reason you don't have any data is because you don't have any extensions installed - this is expected.

It looks fine to me, can you also add panels for the manager metrics?

@mw2000
Copy link
Contributor

mw2000 commented Apr 16, 2024

@onbjerg that sounds good, let me go ahead and do that.

Added, and PR out of draft + ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants