Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metric for the number of ExEx's on a node #7629

Closed
Tracked by #7549
onbjerg opened this issue Apr 14, 2024 · 1 comment · Fixed by #7632
Closed
Tracked by #7549

Add a metric for the number of ExEx's on a node #7629

onbjerg opened this issue Apr 14, 2024 · 1 comment · Fixed by #7632
Assignees
@AbnerZheng
Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 14, 2024 •
edited

Describe the feature

Add a metric for the number of ExEx's on a node. This should go into ExExManagerMetrics, be a Gauge and be set only on creation of the manager, as the number of ExEx's is static over the node's lifetime (if one crashes, the node crashes)

reth/crates/exex/src/manager.rs

Line 121 in 4d79967

pub struct ExExManagerMetrics {

Additionally there should be a panel (one that just displays a number) for the number of ExEx's in Granfa (see #7572)

Additional context

No response
@onbjerg onbjerg added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools A-exex Execution Extensions labels Apr 14, 2024
@onbjerg onbjerg mentioned this issue Apr 14, 2024
Open
@onbjerg onbjerg added the D-good-first-issue Nice and easy! A great choice to get started label Apr 14, 2024
@AbnerZheng
Copy link
Contributor

I can take it.

This was referenced Apr 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbnerZheng AbnerZheng

Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a metric for the number of ExEx's on a node AbnerZheng/reth
2 participants
@AbnerZheng @onbjerg