Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TransactionKind in reth-rpc-types with Alloy's TxKind #7872

Closed
onbjerg opened this issue Apr 25, 2024 · 1 comment
Closed

Replace TransactionKind in reth-rpc-types with Alloy's TxKind #7872

onbjerg opened this issue Apr 25, 2024 · 1 comment

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 25, 2024 

          let's also remove the `TransactionKind` enum since it should no longer be used

edit: ah, nvm, i see it was deleted from primitives. can we also remove TransactionKind in rpc and use alloy's TxKind? this also lets us remove the conversion fn introduced in this pr

Originally posted by @onbjerg in #7859 (review)
@onbjerg
Copy link
Member Author

onbjerg commented Apr 25, 2024

Dupe of #7871

@onbjerg onbjerg closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onbjerg