Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TransactionKind with alloy_primitives::TxKind #7871

Closed
mattsse opened this issue Apr 25, 2024 · 2 comments · Fixed by #7885
Closed

Replace TransactionKind with alloy_primitives::TxKind #7871

mattsse opened this issue Apr 25, 2024 · 2 comments · Fixed by #7885
Assignees
@andrzejSulkowski
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Apr 25, 2024 •
edited

Describe the feature

replace

reth/crates/rpc/rpc-types/src/eth/transaction/typed.rs

Lines 121 to 125 in c7008de

/// Represents the `to` field of a transaction request
///
/// This determines what kind of transaction this is
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub enum TransactionKind {

with alloy_primitives::TxKind

cc @rodrigoherrerai

Additional context

#7859
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Apr 25, 2024
@onbjerg onbjerg mentioned this issue Apr 25, 2024
Closed
@andrzejSulkowski
Copy link
Contributor

Can I do this one?

@rodrigoherrerai
Copy link
Contributor

Perf

@andrzejSulkowski andrzejSulkowski mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrzejSulkowski andrzejSulkowski

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace rpc TransactionKind with alloy_primitives::TxKind andrzejSulkowski/reth
3 participants
@mattsse @rodrigoherrerai @andrzejSulkowski