Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename PipelineHandler #9008

Closed
Tracked by #8742
mattsse opened this issue Jun 21, 2024 · 0 comments
Closed
Tracked by #8742

rename PipelineHandler #9008

mattsse opened this issue Jun 21, 2024 · 0 comments
Assignees
@fgimenez
Labels
A-consensus Related to the consensus engine C-debt Refactor of code section that is hard to understand or maintain

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 21, 2024 •
edited
Loading

reth/crates/engine/tree/src/chain.rs

Line 34 in 83cbcb9

P: PipelineHandler,

we should rename PipelineHandler which is very specific to either

  • BackfillSync or
  • BackfillSyncHandler

which is more generic, our Pipeline sync will then be one flavour of BackfillSync

and update all events/naming etc.
@mattsse mattsse mentioned this issue Jun 21, 2024
Open
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jun 21, 2024
@mattsse mattsse mentioned this issue Jun 21, 2024
Closed
@emhane emhane added the A-consensus Related to the consensus engine label Jun 24, 2024
@fgimenez fgimenez mentioned this issue Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgimenez fgimenez

Labels
A-consensus Related to the consensus engine C-debt Refactor of code section that is hard to understand or maintain
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fgimenez @mattsse @emhane