Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consensus crate and verification functions. #152

Merged
merged 13 commits into from Nov 2, 2022
Merged

Conversation

rakita
Copy link
Collaborator

@rakita rakita commented Oct 31, 2022

Added consensus crate and all verifications that block/header can have.

There are still some pending things, but the main bulk is there.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #152 (37b41d6) into main (ee61be9) will increase coverage by 0.09%.
The diff coverage is 66.16%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   73.60%   73.70%   +0.09%     
==========================================
  Files         159      164       +5     
  Lines       12493    12869     +376     
==========================================
+ Hits         9196     9485     +289     
- Misses       3297     3384      +87     
Impacted Files Coverage Δ
crates/consensus/src/consensus.rs 0.00% <0.00%> (ø)
crates/executor/src/config.rs 0.00% <0.00%> (ø)
crates/executor/src/executor.rs 0.00% <0.00%> (ø)
crates/executor/src/lib.rs 100.00% <ø> (ø)
crates/executor/src/revm_wrap.rs 0.00% <0.00%> (ø)
crates/interfaces/src/executor.rs 0.00% <0.00%> (ø)
crates/interfaces/src/provider/block.rs 0.00% <0.00%> (ø)
crates/libmdbx-rs/src/environment.rs 80.06% <ø> (ø)
crates/net/discv4/src/lib.rs 58.93% <ø> (-0.32%) ⬇️
crates/primitives/src/block.rs 54.54% <ø> (+54.54%) ⬆️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/consensus/src/verification.rs Outdated Show resolved Hide resolved
crates/executor/src/revm_wrap.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Collaborator

mattsse commented Nov 1, 2022

The coverage job can be very noisy, the target of 73,60% is currently problematic since we still do a lot of scaffolding.

should we decrease this @onbjerg ?

@rakita rakita merged commit ac2f3fc into main Nov 2, 2022
@rakita rakita deleted the rakita/chain_mock branch November 2, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants