Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seek_by_key_subkey usage on HistoricalStateProvider #1584

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

joshieDo
Copy link
Collaborator

As the title suggests. We were not filtering for the returned value.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Feb 28, 2023
@joshieDo joshieDo changed the title fix: fix usage seek_by_key_subkey on HistoricalStateProvider fix: usage seek_by_key_subkey on HistoricalStateProvider Feb 28, 2023
@joshieDo joshieDo changed the title fix: usage seek_by_key_subkey on HistoricalStateProvider fix: seek_by_key_subkey usage on HistoricalStateProvider Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #1584 (ca82e27) into main (5e0fa44) will increase coverage by 0.10%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   74.99%   75.09%   +0.10%     
==========================================
  Files         372      372              
  Lines       43610    43613       +3     
==========================================
+ Hits        32706    32752      +46     
+ Misses      10904    10861      -43     
Flag Coverage Δ
integration-tests 21.42% <0.00%> (+<0.01%) ⬆️
unit-tests 69.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/storage/db/src/abstraction/cursor.rs 98.66% <ø> (ø)
...storage/provider/src/providers/state/historical.rs 92.00% <100.00%> (+0.10%) ⬆️
crates/net/eth-wire/src/p2pstream.rs 79.41% <0.00%> (-0.18%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (ø)
crates/net/discv4/src/lib.rs 65.82% <0.00%> (+0.21%) ⬆️
crates/net/eth-wire/src/ethstream.rs 84.44% <0.00%> (+0.47%) ⬆️
crates/transaction-pool/src/pool/txpool.rs 61.56% <0.00%> (+0.49%) ⬆️
crates/stages/src/stages/sender_recovery.rs 91.48% <0.00%> (+0.53%) ⬆️
crates/net/eth-wire/src/capability.rs 75.00% <0.00%> (+0.73%) ⬆️
crates/net/network/src/listener.rs 83.72% <0.00%> (+2.32%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 6cdf0a3 into main Feb 28, 2023
@mattsse mattsse deleted the joshie/fix-seek-subk branch February 28, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants