-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): Add StorageProvider impl, table changes #172
Conversation
15c19d8
to
1163b4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 70.25% 70.13% -0.13%
==========================================
Files 188 191 +3
Lines 15278 15407 +129
==========================================
+ Hits 10734 10805 +71
- Misses 4544 4602 +58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! left minor suggestions
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Added:
StorageProvider
: 'latest,
history_by_block_num, history_block_block_hash
Additionally few small cleanups:
SeekKey
removed fromTable
asSubKey
is present in DupTable, remove some lifetime restrictions from DbTx, removed nightly toolchain, added bytecode table.