New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitive): Signer recovery #179
Conversation
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 69.97% 70.11% +0.14%
==========================================
Files 191 192 +1
Lines 15408 15604 +196
==========================================
+ Hits 10781 10941 +160
- Misses 4627 4663 +36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left some comments
Done some cleanup and found bug in hash calculation that took me some time to find. in essence for typed transaction hash was calculated over rlp header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I added signer recovery with seckp256k1 lib.
there are a few additional changes in consensus for tx validity that are unrelated to recovery but seem okay to be merged, I will continue working on those.