Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow --db before or after subcommand #1827

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Mar 18, 2023

Closes #1825

@onbjerg onbjerg added C-enhancement New feature or request A-cli Related to the reth CLI labels Mar 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #1827 (216a017) into main (7ac06cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   73.54%   73.54%           
=======================================
  Files         410      410           
  Lines       50510    50510           
=======================================
+ Hits        37146    37150    +4     
+ Misses      13364    13360    -4     
Flag Coverage Δ
integration-tests 19.72% <0.00%> (-0.01%) ⬇️
unit-tests 67.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/db/mod.rs 3.53% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL global

@mattsse mattsse merged commit d774d91 into main Mar 18, 2023
@mattsse mattsse deleted the onbjerg/global-opts branch March 18, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--db <path> argument unintuitive in db subcommand
3 participants