Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(txpool): add listeners for all transactions #59

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat(txpool): add listeners for all transactions #59

merged 1 commit into from
Oct 13, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 13, 2022

Allow registering listeners for all added transaction objects

This adds a new listener set that sends newly added transactions over a set of Sender channels.

gakonst
gakonst approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would think about later adding a benchmark which checks how fast we can validate transactions & move them across the subpools as they come in. Also the naming ready vs pending seems a bit confusing?

@gakonst gakonst merged commit 55768a5 into main Oct 13, 2022
@gakonst gakonst deleted the matt/add-general-tx-listener branch October 13, 2022 17:47
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 13, 2022

Also the naming ready vs pending seems a bit confusing?

I'll create an issue for this to go over everything and check consistent naming

@mattsse mattsse mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst