Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug hashes buffered for busy peer gave false-positive on eth68 check #6427

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix bug hashes buffered for busy peer gave false-positive on eth68 check #6427

merged 3 commits into from
Feb 5, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 5, 2024 •
edited
Loading

Closes #6424.

  • Passes around message version of an announcement atomically with the announcement data. Ensures correct message version is used in log output as well as in checks.
  • Renames method filter_unseen_hashes to filter_unseen_and_pending_hashes to better reflect its behaviour and updates logs accordingly.

mattsse
mattsse approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

lgtm

@emhane emhane enabled auto-merge February 5, 2024 22:39
@emhane emhane added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 75132da Feb 5, 2024
28 checks passed
@emhane emhane deleted the emhane/check-msg-version-bug branch February 5, 2024 22:49
@emhane emhane mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsafe way to check if announcement is eth68
2 participants
@emhane @mattsse