Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BestTransactionsWithAttributes blob fee checks #6674

Merged
merged 11 commits into from Feb 22, 2024
Merged

feat: add BestTransactionsWithAttributes blob fee checks #6674

merged 11 commits into from Feb 22, 2024

Conversation

allnil
Copy link
Contributor

@allnil allnil commented Feb 19, 2024 •
edited by mattsse

Draft
Started to work closes #6383

mattsse
mattsse requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going in the right direction, ty.

a few things left

crates/transaction-pool/src/pool/best.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/pool/blob.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/pool/txpool.rs Show resolved Hide resolved
@allnil allnil marked this pull request as ready for review February 20, 2024 18:03
@allnil allnil requested a review from mattsse February 20, 2024 18:04
@Rjected Rjected changed the title Feat/dynamic blob fee check feat: add directional blob fee checks in BestTransactionWithAttributes Feb 20, 2024
@Rjected Rjected changed the title feat: add directional blob fee checks in BestTransactionWithAttributes feat: add BestTransactionsWithAttributes blob fee checks Feb 20, 2024
Rjected
Rjected previously requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question about whether or not we should return early if blob_fee is None

crates/transaction-pool/src/pool/blob.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/pool/blob.rs Outdated Show resolved Hide resolved
@allnil allnil requested a review from Rjected February 21, 2024 19:35
mattsse
mattsse approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

I've added a few more relevant docs

@mattsse mattsse added this pull request to the merge queue Feb 22, 2024
Merged via the queue into paradigmxyz:main with commit a272bbb Feb 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement missing dynamic blob fee change check for Transactionpool::best_transactions_with_attributes
3 participants
@allnil @Rjected @mattsse