Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docs tx manager #6682

Merged
merged 3 commits into from Feb 20, 2024
Merged

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 19, 2024

Improved use of whitespace to read defaults for constants.

@emhane emhane added C-docs An addition or correction to our documentation C-debt A section of code is hard to understand or change labels Feb 19, 2024
@@ -1,5 +1,5 @@
use super::{
DEFAULT_SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESPONSE_ON_PACK_GET_POOLED_TRANSACTIONS_REQUEST,
DEFAULT_SOFT_LIMIT_BYTE_SIZE_POOLED_TRANSACTIONS_RESP_ON_PACK_GET_POOLED_TRANSACTIONS_REQ,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a tad shorter @Rjected

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit cb61334 Feb 20, 2024
29 checks passed
@Rjected Rjected deleted the emhane/improve-readability-tx-constants branch February 20, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A section of code is hard to understand or change C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants